Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating seldon core to v1.17.1 #2532

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

SachinVarghese
Copy link
Contributor

@SachinVarghese SachinVarghese commented Sep 14, 2023

Description of your changes:
Updating seldon core to v1.17.1

Checklist:

  • Unit tests pass:
    Make sure you have installed kustomize == 3.2.1
    1. make generate-changed-only
    2. make test

Signed-off-by: Sachin Varghese <sachin.mathew31@gmail.com>
@google-cla
Copy link

google-cla bot commented Sep 14, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Signed-off-by: Sachin Varghese <sachin.mathew31@gmail.com>
@juliusvonkohout
Copy link
Member

Hello, you have to sign the CLA. I really like that people keep seldon up to date.

@SachinVarghese SachinVarghese marked this pull request as ready for review September 15, 2023 08:52
@SachinVarghese
Copy link
Contributor Author

SachinVarghese commented Sep 15, 2023

Hello, you have to sign the CLA. I really like that people keep seldon up to date.

Thank you, I have signed the CLA, the PR should be ready for review now. Is it likely that this PR can make it to the next release (1.8)?

@juliusvonkohout
Copy link
Member

Hello, you have to sign the CLA. I really like that people keep seldon up to date.

Thank you, I have signed the CLA, the PR should be ready for review now. Is it likely that this PR can make it to the next release (1.8)?

@annajung @kimwnasptd @DnPlas do we want to Backport this to 1.8?

@SachinVarghese is it not enough to have it in the master branch and in 1.9? Is it needed for Kubernetes 1.26?

@SachinVarghese
Copy link
Contributor Author

Hello, you have to sign the CLA. I really like that people keep seldon up to date.

Thank you, I have signed the CLA, the PR should be ready for review now. Is it likely that this PR can make it to the next release (1.8)?

@annajung @kimwnasptd @DnPlas do we want to Backport this to 1.8?

@SachinVarghese is it not enough to have it in the master branch and in 1.9? Is it needed for Kubernetes 1.26?

The previous version of Seldon Core was 1.15.0, which doesn't run on Kubernetes 1.26. So it would be good to have it in the 1.8 release if possible. If not, we can have it in the master for the next release.

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Sep 15, 2023

@axsaucedo
@adriangonz
@cliveseldon
@ryandawsonuk

Since you are the owners of seldon here, are you still all dedicated to maintaining it?

Given the commit history it seems that @ryandawsonuk and @adriangonz stopped commiting two years ago.

@adriangonz
Copy link
Member

Hey @juliusvonkohout ,

@ryandawsonuk and @axsaucedo no longer work with Seldon. However, @cliveseldon and myself are still dedicated to it (as well as others within the team, like @SachinVarghese).

@juliusvonkohout
Copy link
Member

Hey @juliusvonkohout ,

@ryandawsonuk and @axsaucedo no longer work with Seldon. However, @cliveseldon and myself are still dedicated to it (as well as others within the team, like @SachinVarghese).

Then lets remove these two in the PR as well and add @SachinVarghese to the owners

Signed-off-by: Sachin Varghese <sachin.mathew31@gmail.com>
@juliusvonkohout
Copy link
Member

/lgtm
@adriangonz do you see anything missing? otherwise i recommend to approve it. with '/approve'

@DnPlas
Copy link
Contributor

DnPlas commented Sep 18, 2023

Hello, you have to sign the CLA. I really like that people keep seldon up to date.

Thank you, I have signed the CLA, the PR should be ready for review now. Is it likely that this PR can make it to the next release (1.8)?

@annajung @kimwnasptd @DnPlas do we want to Backport this to 1.8?
@SachinVarghese is it not enough to have it in the master branch and in 1.9? Is it needed for Kubernetes 1.26?

The previous version of Seldon Core was 1.15.0, which doesn't run on Kubernetes 1.26. So it would be good to have it in the 1.8 release if possible. If not, we can have it in the master for the next release.

hi there, yes we have to backport this change also to 1.8, once we merge this PR.

@ukclivecox
Copy link
Contributor

/lgtm

@ukclivecox
Copy link
Contributor

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon, SachinVarghese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 560fc12 into kubeflow:master Sep 18, 2023
3 checks passed
@SachinVarghese SachinVarghese deleted the core-update branch September 18, 2023 16:23
DnPlas pushed a commit to DnPlas/manifests that referenced this pull request Sep 19, 2023
* Updating seldon core to v1.17.1

Signed-off-by: Sachin Varghese <sachin.mathew31@gmail.com>

* fix CI test

Signed-off-by: Sachin Varghese <sachin.mathew31@gmail.com>

* Adding SachinVarghese to seldon owners

Signed-off-by: Sachin Varghese <sachin.mathew31@gmail.com>

---------

Signed-off-by: Sachin Varghese <sachin.mathew31@gmail.com>
google-oss-prow bot pushed a commit that referenced this pull request Sep 19, 2023
* Updating seldon core to v1.17.1



* fix CI test



* Adding SachinVarghese to seldon owners



---------

Signed-off-by: Sachin Varghese <sachin.mathew31@gmail.com>
Co-authored-by: Sachin Varghese <sachin.mathew31@gmail.com>
@juliusvonkohout
Copy link
Member

juliusvonkohout commented Mar 4, 2024

@SachinVarghese @adriangonz @ukclivecox can you upgrade Seldon to 1.18.x? We want to support Kubernetes 1.27-1.29 in Kubeflow 1.9

@adriangonz
Copy link
Member

Hey @juliusvonkohout ,

None of the previous maintainers mentioned above work for Seldon anymore (nor work on the Seldon Core project).

For next steps on this one, it would be best to check with either @ramonpzg or @ahousley.

@ramonpzg
Copy link

Hi @juliusvonkohout -- >v1.18 is now compatible with k8s 1.27 :)

We are keeping track of it here https://docs.seldon.io/projects/seldon-core/en/latest/workflow/install.html

@juliusvonkohout
Copy link
Member

Hi @juliusvonkohout -- >v1.18 is now compatible with k8s 1.27 :)

We are keeping track of it here https://docs.seldon.io/projects/seldon-core/en/latest/workflow/install.html

can you create a PR then to update? We also need to update the owners file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants