-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kubeflow/pipelines manifests from 2.0.5 #2623
Update kubeflow/pipelines manifests from 2.0.5 #2623
Conversation
The git diff looks empy which is good
I will add a script to apps/pipeline to automate the manifest synchronization. |
Lets use #2625 for updates |
Maybe you need to cherry pick some test fixes from #2544 |
@chensun Need your help here. This PR is crucial to release Kubeflow 1.8.1. Integration test is falling because of something related to cert-manager. Can you take a look? |
@rimolive this has to be merged to master as well. Usually we start with Master and cherry pick to the 1.8 branch. |
Cert-manager was introduced by Amazon folks, my understanding is they should only apply to AWS deployment. |
cert-manager is used by default. Sometimes it just does not become ready fast enough. a wait for cert-manger as done here might help.
|
Now we get
|
https://github.com/kubeflow/manifests/blob/master/tests/gh-actions/kf-objects/test_pipeline.py must be adjusted or we downgrade |
@rimolive Somewhere around here manifests/.github/workflows/pipeline_kind_test.yaml Lines 42 to 46 in 8f76ccb
Maybe the timeout is too tight, but i would really like to drop this outdated argo file and test and just check the workflow status directly with kubectl |
@rimolive i need access to your branch to sign my commits. You can also sign them if you want. |
Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com>
With KFP 2.0 release, we need to bump SDK version to the latest release (2.7.0) Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com>
Why did you revert my fix for KFP 2.7.0 to 1.8.22? We can stay on the 1.8.22 SDK. V2 pipelines are still on a beta level. Or at least we should test v1 and V2 pipelines. |
Sorry, I did not notice you added that commit. Can you send it again? |
It is just replacing the value 2.7.0 with 1.8.22 |
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Ok we have to increase the timeout i guess, but that is something for the master branch. |
/lgtm |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: juliusvonkohout, rimolive The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Update kubeflow/pipelines manifests from 2.0.5 Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com> * Fix integration test With KFP 2.0 release, we need to bump SDK version to the latest release (2.7.0) Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com> * only v1 is tested for now. We can add tests for v2 later on. Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> --------- Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Co-authored-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
* Update kubeflow/pipelines manifests from 2.0.5 Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com> * Fix integration test With KFP 2.0 release, we need to bump SDK version to the latest release (2.7.0) Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com> * only v1 is tested for now. We can add tests for v2 later on. Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> --------- Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Co-authored-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
* Merge pull request #2626 from rimolive/sync-kubeflow-kfp-tekton-manifests-2.0.5 Update kubeflow/kfp-tekton manifests from 2.0.5 Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Update kubeflow/pipelines manifests from 2.0.5 (#2623) * Update kubeflow/pipelines manifests from 2.0.5 Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com> * Fix integration test With KFP 2.0 release, we need to bump SDK version to the latest release (2.7.0) Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com> * only v1 is tested for now. We can add tests for v2 later on. Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> --------- Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Co-authored-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * fix readme Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> --------- Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com> Co-authored-by: Ricardo Martinelli de Oliveira <rmartine@redhat.com>
Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
Checklist:
Make sure you have installed kustomize == 5.0.3
make generate-changed-only
make test