-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix most kustomize v5 warnings #2653
fix most kustomize v5 warnings #2653
Conversation
@juliusvonkohout I've merged the PRs into one. As I mentioned in the PR description, I am not sure on how to fix |
@AndersBennedsgaard we have commonLabels: in many components. I am not sure whether we should switch partially over to the other method (which i am also using myself). What is your argument for doing so? Maybe it is better to only do the kustomize 5 changes for now. |
@diegolovison can you verify this on your local cluster? |
@AndersBennedsgaard patches/clusterrole-patch.yaml is not accepted by kustomize 5 i guess. Can you check how we can have multiple resources in the same file with kustomize 5 ? Maybe there is a new way to have a list of resources in a single file. |
Because |
If common labels is deprecated this is fine. I looked at multiple patches per file and found kubernetes-sigs/kustomize#5049 |
@juliusvonkohout should I split the patches into separate files instead then? |
Maybe we have to upgrade to kustomize 5.3.0 kubernetes-sigs/kustomize#5194 |
Try with kustomize 5.3.0 first please. If that works we might just upgrade kustomize |
I am already using 5.3, which works as expected Edit: it seems to have been fixed in 5.2.1: https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize%2Fv5.2.1 |
@rimolive based on the above comments i want to upgrade to kustomize 5.2.1+ and reflect this in the readme as well. |
If we are going to start support kustomize 5.x.x from this PR, I would like to ask to change: |
#2654 5.2.1 seems to be working with the manifests |
@kimwnasptd what do you think? |
Yes it is in #2654 |
@juliusvonkohout Are we good with merging this PR as we moved to 5.2.1? |
@rimolive I think it would be better to hold this until #2654 has been merged, so unit tests can pass. manifests/common/knative/README.md Line 40 in 68652a1
|
@AndersBennedsgaard feel free to rebase to master. I merged the other PR. |
7f64e1b
to
a3b2e8d
Compare
a3b2e8d
to
2ea2fa1
Compare
Signed-off-by: Anders Bennedsgaard <abbennedsgaard@gmail.com>
2ea2fa1
to
107856b
Compare
I had a couple of git issues, but I think it is fine now. I have tried to add a patch for deleting the Knative-serving gateway as mentioned in the README. Do you think this is the right approach? |
I might be able to review this on Monday. |
Sorry for the delay, i probably have to postpone this to next week. |
The diff seems to be zero /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndersBennedsgaard, juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Anders Bennedsgaard <abbennedsgaard@gmail.com>
Which issue is resolved by this Pull Request:
Related to #2388
Description of your changes:
Fix most Kustomize v5 warnings related to for
common/
.The warning about
vars
being deprecated is still present foroidc-client/oidc-authservice/base/kustomization.yaml
as I weren't successful in fixing it without changes.kustomize build generates no changes between old and new version.
Checklist:
Make sure you have installed kustomize == 5.0.3
make generate-changed-only
make test