Update kubeflow/training-operator manifests from v1.8.0-rc.0 #2699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, I think we should streamline the synchronization script here as well. Feel also free to change it as long as you change all scripts accordingly. |
Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com>
rimolive
force-pushed
the
sync-kubeflow-training-operator-manifests-v1.8.0-rc.0
branch
from
e11c0eb to
e20607c
Compare
|
@juliusvonkohout I updated the sync script. Would you mind take a look? |
|
i did not check the added rbac roles, but that is something for the training operator folks For synchronizing and rc0 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout, rimolive The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
doncorsean
pushed a commit
to doncorsean/kubeflow-manifests
that referenced
this pull request
Jul 18, 2024
…w#2699) Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
Checklist:
Make sure you have installed kustomize == 5.2.1+
make generate-changed-onlymake test