Sync kubeflow model registry manifests v0.2.1-alpha #2737
Conversation
Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
|
Thanks @tarilabs ! /lgtm |
tarilabs
force-pushed
the
sync-kubeflow-model-registry-manifests-v0.2.1-alpha
branch
from
082fecd to
d50bf06
Compare
tarilabs
force-pushed
the
sync-kubeflow-model-registry-manifests-v0.2.1-alpha
branch
4 times, most recently
from
b6037d9 to
3abe407
Compare
Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
tarilabs
force-pushed
the
sync-kubeflow-model-registry-manifests-v0.2.1-alpha
branch
from
3abe407 to
4dbc864
Compare
|
Tested locally as well and it looks good! /lgtm |
| - name: Dry-run KF Model Registry REST API | ||
| run: | | ||
| echo "Dry-run KF Model Registry REST API..." | ||
| export KF_TOKEN="$(kubectl -n default create token default)" |
There was a problem hiding this comment.
We should probably user a proper kubeflow user namespace as in other m2m tests instead of just "default"
There was a problem hiding this comment.
this is exactly per KServe test:
There was a problem hiding this comment.
Probably something we should fix there as well. But that is for another PR @lampajr Ill approve for now.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
thanks @juliusvonkohout @lampajr !! 🚀 👍 |
* Update kubeflow/model-registry manifests from v0.2.1-alpha Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com> * update sync- file Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com> * add test for REST API Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com> --------- Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
* Update kubeflow/model-registry manifests from v0.2.1-alpha Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com> * update sync- file Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com> * add test for REST API Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com> --------- Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
Pull Request Template for Kubeflow manifests Issues
sync-model-registry-manifests.sherrors✏️ A brief description of the changes
per description above
📦 List any dependencies that are required for this change
none
🐛 If this PR is related to an issue, please put the link of the issue here.
none
✅ Unit Test Checklist
these manifests are tested in KF/model-registry repo.
the test addition was demonstrated with: kubeflow/model-registry#101
✅ Contributor checklist
DCOcheck)cla/googlecheck)cc @lampajr