Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync kserve manifests 0.13.0 #2751

Merged

Conversation

ca-scribner
Copy link
Contributor

Updates kserve to v0.13.0 from v0.12.1

This update was generated using the procedure from contrib/kserve/UPGRADE.md, not using hacks/sync-kserve-kserve-manifests.sh, because kserve appears to have forgotten to add 0.13.0 to their install/ directory. Instead, the manifests here have been pulled directly from the 0.13.0 release assets

This update was generated using https://github.com/kubeflow/manifests/blob/master/contrib/kserve/Makefile to pull manifests from the kserve release assets (https://github.com/kserve/kserve/releases/tag/v0.13.0).  The hack update script (https://github.com/kubeflow/manifests/blob/master/hack/sync-kserve-kserve-manifests.sh) was not used because kserve appears to have forgotten to include v0.13.0 in their installs directory.

Signed-off-by: Andrew Scribner <ca.scribner+1@gmail.com>
Note that because kserve appears to have forgotten to include the manifests for 0.13.0 at the expected location in their repo, this script did not actually work for updating to 0.13.0.

Signed-off-by: Andrew Scribner <ca.scribner+1@gmail.com>
@ca-scribner ca-scribner force-pushed the sync-kserve-manifests-0.13.0 branch from e4caf9b to eeae13e Compare June 10, 2024 17:52
@juliusvonkohout
Copy link
Member

@ca-scribner Please tag the kserve maintainers. I would like to get approval from one of them.

@ca-scribner
Copy link
Contributor Author

@juliusvonkohout
Copy link
Member

@diegolovison can you test this?

@rimolive we also need this in rc.2

@yuzisun
Copy link
Member

yuzisun commented Jun 18, 2024

/lgtm

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Jun 18, 2024

/approve

Since the kserve maintainers agreed

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 29bd21a into kubeflow:master Jun 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants