From a467999027ad6b8547c42450a383b2455a820fa3 Mon Sep 17 00:00:00 2001
From: Griffin-Sullivan <gsulliva@redhat.com>
Date: Mon, 19 Aug 2024 12:36:20 -0400
Subject: [PATCH] Update tsconfig files to include all the frontend TS / JS
 files and correctly transpile

Signed-off-by: Griffin-Sullivan <gsulliva@redhat.com>
---
 .../ui/frontend/src/__tests__/cypress/tsconfig.json |  4 +---
 clients/ui/frontend/src/app/App.tsx                 |  4 ++--
 clients/ui/frontend/src/app/AppRoutes.tsx           |  8 ++++----
 clients/ui/frontend/src/app/NavSidebar.tsx          |  2 +-
 clients/ui/frontend/src/index.tsx                   |  2 +-
 clients/ui/frontend/tsconfig.json                   | 13 ++++---------
 6 files changed, 13 insertions(+), 20 deletions(-)

diff --git a/clients/ui/frontend/src/__tests__/cypress/tsconfig.json b/clients/ui/frontend/src/__tests__/cypress/tsconfig.json
index ac8b479f2..a6dac7707 100644
--- a/clients/ui/frontend/src/__tests__/cypress/tsconfig.json
+++ b/clients/ui/frontend/src/__tests__/cypress/tsconfig.json
@@ -1,10 +1,8 @@
 {
   "extends": "../../../tsconfig.json",
   "include": ["../../**/*.ts"],
-  "exclude": ["node_modules", "public"],
+  "exclude": ["node_modules", "dist"],
   "compilerOptions": {
-    // TODO https://github.com/cypress-io/cypress/issues/26203
-    "sourceMap": false,
     "types": ["node", "cypress", "@testing-library/cypress", "cypress-axe"]
   }
 }
diff --git a/clients/ui/frontend/src/app/App.tsx b/clients/ui/frontend/src/app/App.tsx
index d9be35e50..2183e990a 100644
--- a/clients/ui/frontend/src/app/App.tsx
+++ b/clients/ui/frontend/src/app/App.tsx
@@ -1,7 +1,7 @@
 import * as React from 'react';
 import '@patternfly/react-core/dist/styles/base.css';
-import AppRoutes from '@app/AppRoutes';
-import '@app/app.css';
+import AppRoutes from './AppRoutes';
+import './app.css';
 import {
   Flex,
   Masthead,
diff --git a/clients/ui/frontend/src/app/AppRoutes.tsx b/clients/ui/frontend/src/app/AppRoutes.tsx
index da6fc5c2c..fce6104f4 100644
--- a/clients/ui/frontend/src/app/AppRoutes.tsx
+++ b/clients/ui/frontend/src/app/AppRoutes.tsx
@@ -1,9 +1,9 @@
 import * as React from 'react';
 import { Route, Routes } from 'react-router-dom';
-import { Dashboard } from '@app/Dashboard/Dashboard';
-import { Support } from '@app/Support/Support';
-import { NotFound } from '@app/NotFound/NotFound';
-import { Admin } from '@app/Settings/Admin';
+import { Dashboard } from './Dashboard/Dashboard';
+import { Support } from './Support/Support';
+import { NotFound } from './NotFound/NotFound';
+import { Admin } from './Settings/Admin';
 
 export const isNavDataGroup = (navItem: NavDataItem): navItem is NavDataGroup => 'children' in navItem;
 
diff --git a/clients/ui/frontend/src/app/NavSidebar.tsx b/clients/ui/frontend/src/app/NavSidebar.tsx
index 297be6109..e0c24606b 100644
--- a/clients/ui/frontend/src/app/NavSidebar.tsx
+++ b/clients/ui/frontend/src/app/NavSidebar.tsx
@@ -8,7 +8,7 @@ import {
   PageSidebar,
   PageSidebarBody,
 } from '@patternfly/react-core';
-import { useNavData, isNavDataGroup, NavDataHref, NavDataGroup } from '@app/AppRoutes';
+import { useNavData, isNavDataGroup, NavDataHref, NavDataGroup } from './AppRoutes';
 
 const NavHref: React.FC<{ item: NavDataHref }> = ({ item }) => (
   <NavItem
diff --git a/clients/ui/frontend/src/index.tsx b/clients/ui/frontend/src/index.tsx
index aa2febc9f..d889f9866 100644
--- a/clients/ui/frontend/src/index.tsx
+++ b/clients/ui/frontend/src/index.tsx
@@ -1,7 +1,7 @@
 import React from 'react';
 import ReactDOM from 'react-dom/client';
 import { BrowserRouter as Router } from 'react-router-dom';
-import App from '@app/App';
+import App from './app/App';
 
 if (process.env.NODE_ENV !== 'production') {
   const config = {
diff --git a/clients/ui/frontend/tsconfig.json b/clients/ui/frontend/tsconfig.json
index 94a24c59c..99bc97a4b 100644
--- a/clients/ui/frontend/tsconfig.json
+++ b/clients/ui/frontend/tsconfig.json
@@ -15,18 +15,12 @@
     "forceConsistentCasingInFileNames": true,
     "noImplicitReturns": true,
     "noImplicitThis": true,
-    "noImplicitAny": false,
+    "noImplicitAny": true,
     "allowJs": true,
     "esModuleInterop": true,
     "allowSyntheticDefaultImports": true,
     "strict": true,
     "paths": {
-      "@app/*": [
-        "src/app/*"
-      ],
-      "@assets/*": [
-        "node_modules/@patternfly/react-core/dist/styles/assets/*"
-      ],
       "~/*": ["./*"]
     },
     "importHelpers": true,
@@ -37,9 +31,10 @@
     "**/*.tsx",
     "**/*.jsx",
     "**/*.js",
-    ".eslintrc.js"
   ],
   "exclude": [
-    "node_modules"
+    "node_modules",
+    "dist",
+    "src/__tests__/cypress"
   ]
 }