From b87eee255c07e08e7486f4f04a71f4a844376591 Mon Sep 17 00:00:00 2001 From: ddalvi Date: Thu, 17 Oct 2024 00:44:44 -0400 Subject: [PATCH] Re-enable test_dockerfile_can_contain_custom_kfp_package Removed the skip unit test decorator that was previously added to bypass the test due to failure (referencing issue #11038). The issue reported in #11038 was caused due to the Dockerfile referencing to Python 3.7. With the Python version updated to 3.9, the test now passes consistently. This commit re-enables the test to ensure proper validation of Dockerfile creation and KFP package. Signed-off-by: ddalvi --- sdk/python/kfp/cli/component_test.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/sdk/python/kfp/cli/component_test.py b/sdk/python/kfp/cli/component_test.py index d6240efdbe1..c44e78d9020 100644 --- a/sdk/python/kfp/cli/component_test.py +++ b/sdk/python/kfp/cli/component_test.py @@ -579,9 +579,6 @@ def test_existing_dockerfile_can_be_overwritten(self): COPY . . ''')) - @unittest.skip( - "Skipping this test as it's failing. Refer to https://github.com/kubeflow/pipelines/issues/11038" - ) def test_dockerfile_can_contain_custom_kfp_package(self): component = _make_component( func_name='train', target_image='custom-image') @@ -608,7 +605,7 @@ def test_dockerfile_can_contain_custom_kfp_package(self): file_start = textwrap.dedent('''\ # Generated by KFP. - FROM python:3.9 + FROM python:3.12 WORKDIR /usr/local/src/kfp/components COPY runtime-requirements.txt runtime-requirements.txt