Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Setting a task group name #10274

Closed
yas0nia opened this issue Nov 29, 2023 · 4 comments
Closed

[feature] Setting a task group name #10274

yas0nia opened this issue Nov 29, 2023 · 4 comments
Labels
area/backend kind/feature lifecycle/stale The issue / pull request is stale, any activities remove this label.

Comments

@yas0nia
Copy link

yas0nia commented Nov 29, 2023

Feature Area

/area backend

What feature would you like to see?

Able to set a custom name for a task group:
https://github.com/kubeflow/pipelines/blob/master/sdk/python/kfp/dsl/tasks_group.py#L78

What is the use case or pain point?

when using dsl.If and dsl.Else, they get grouped in a task group with an automatically generated name, which makes the pipeline less readable
Screenshot 2023-11-29 at 13 21 10

Is there a workaround currently?

Custom "head" if component (instead of deprecated dsl.Condition) to mimic a task group, I guess

Love this idea? Give it a 👍.

@yas0nia yas0nia changed the title [feature] <Description> [feature] Setting a task group name Nov 29, 2023
@chensun
Copy link
Member

chensun commented Jan 4, 2024

You can customize the group name via the name parameter: https://kubeflow-pipelines.readthedocs.io/en/latest/source/dsl.html#kfp.dsl.Condition.__init__.name

@yas0nia
Copy link
Author

yas0nia commented Jan 11, 2024

@chensun thanks for the info! The group is created automatically in kfp 2.4, i don't create it myself in the code, that's why I can't assign a name to it. I don't have this UI issue in kfp 2.3.

Code snippet:

@dsl.pipeline(name="my-pipeline", description="My new pipeline")
def my_pipeline(
    input_params: Dict[Any, Any],
) -> None:
    
   first_step = first_component.set_display_name("First step")

    with dsl.If(condition based on my first step):
        #some logic here
    with dsl.Else(
            name="proceed with another component",
        ):
            #some logic here too

these if/else conditions are automatically grouped together in the UI in kfp 2.4. Not sure about 2.5, not happening in 2.3 tho. I like the grouping, but I don't like the automatically assigned name..

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Mar 14, 2024
Copy link

github-actions bot commented Apr 5, 2024

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend kind/feature lifecycle/stale The issue / pull request is stale, any activities remove this label.
Projects
Status: Closed
Development

No branches or pull requests

2 participants