Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] The UI does not account for the artifact-repositories configmap #11339

Closed
droctothorpe opened this issue Oct 30, 2024 · 0 comments · Fixed by #11354
Closed

[frontend] The UI does not account for the artifact-repositories configmap #11339

droctothorpe opened this issue Oct 30, 2024 · 0 comments · Fixed by #11354

Comments

@droctothorpe
Copy link
Contributor

droctothorpe commented Oct 30, 2024

We contributed #11010 in August to resolve a frontend bug where component logs were no longer accessible after pods and Argo workflows were GCed. This PR solved the problem for the overwhelming majority of use cases, but we discovered a corner case that it doesn't account for.

Specifically, AWF supports dynamic key prefixes that vary on a per namespace basis using the namespaced artifact-repositories configmap. Additional information about that model is available here.

To support this pattern, we want to extend createPodLogsMinioRequestConfig to call a standalone function that gets the configmap and extracts the keyPrefix field.

It will be decomposed, narrowly scoped, and disabled by default. Users who leverage namespace-scoped key prefixes can toggle it on with an environment variable or by modifying config.ts.

We plan to start working on this soon. Please let us know if there are any objections to the proposed design. Thank you!

cc @zijianjoy


Impacted by this bug? Give it a 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant