Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): Backport fixes in kubeflow/pipelines#11075 #11392

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rimolive
Copy link
Member

Introduced back the functions to convert k8s size values to float, but moved to kfp.dsl.utils

Description of your changes:
fixes #11390

Checklist:

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Nov 19, 2024
@rimolive rimolive force-pushed the cpu_memory_requests_limits branch 6 times, most recently from 02daafe to e11eb4c Compare November 20, 2024 16:03
@google-oss-prow google-oss-prow bot added size/M and removed size/L labels Nov 20, 2024
@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Nov 20, 2024
@github-actions github-actions bot added the ci-passed All CI tests on a pull request have passed label Nov 20, 2024
@rimolive rimolive force-pushed the cpu_memory_requests_limits branch 2 times, most recently from dc32c7e to 293792f Compare November 20, 2024 19:56
Introduced back the functions to convert k8s size values to float, but
moved to kfp.dsl.utils

Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com>
@github-actions github-actions bot added ci-passed All CI tests on a pull request have passed and removed ci-passed All CI tests on a pull request have passed labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed All CI tests on a pull request have passed size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sdk] Pipelines generated from kfp 2.10 ignore cpu/memory requests/limits
1 participant