Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): block dsl.importer usage in KFP OSS. Fixes: #6323 #6330

Merged
merged 2 commits into from
Aug 16, 2021

Conversation

chensun
Copy link
Member

@chensun chensun commented Aug 13, 2021

Description of your changes:
Block using importer in KFP OSS since importer doesn't have a normal container implementation yet.
Fixes: #6323

Checklist:

@chensun chensun requested a review from ji-yaqi August 13, 2021 06:07
@google-cla google-cla bot added the cla: yes label Aug 13, 2021
@chensun chensun changed the title fix(sdk): block dsl.importer usage in KFP OSS fix(sdk): block dsl.importer usage in KFP OSS. Fixes: #6323 Aug 13, 2021
Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thank you! clear error messages are super helpful

sdk/python/kfp/compiler/compiler.py Outdated Show resolved Hide resolved
@Bobgy
Copy link
Contributor

Bobgy commented Aug 16, 2021

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 434e5c3 into kubeflow:master Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sdk]: AttributeError: 'NoneType' object has no attribute 'command'
4 participants