Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): Import mock from stdlib and drop dependency. #6456

Merged
merged 2 commits into from
Aug 31, 2021

Conversation

jmcarp
Copy link
Contributor

@jmcarp jmcarp commented Aug 27, 2021

Description of your changes:

I noticed that we're installing mock, which is now available in the stdlib. This patch drops the mock dependency and imports it from unittest.

Checklist:

@google-oss-robot
Copy link

Hi @jmcarp. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@NikeNano
Copy link
Member

/ok-to-test

@NikeNano
Copy link
Member

Do the current version of unittest used needs to be updated to allow this @jmcarp?

@jmcarp
Copy link
Contributor Author

jmcarp commented Aug 27, 2021

I don't think so @NikeNano. The unittest package is part of the standard library, and it's included mock since python 3.3. We're already using it in many of the tests, just not all of them.

@chensun
Copy link
Member

chensun commented Aug 28, 2021

Thanks @jmcarp

Can you also remove it from here:

@chensun
Copy link
Member

chensun commented Aug 28, 2021

/ok-to-test

@chensun
Copy link
Member

chensun commented Aug 30, 2021

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chensun
Copy link
Member

chensun commented Aug 31, 2021

/retest

@google-oss-robot google-oss-robot merged commit f43ecc2 into kubeflow:master Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants