-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change release tags to vX.Y.Z. Fixes #5954 #5974
feat: change release tags to vX.Y.Z. Fixes #5954 #5974
Conversation
Please search for mm_ver or mm.ver |
Found it: Line 211 in df1ab4d
Line 225 in df1ab4d
However I dont think we need to update it:
gives :
Where the expected out put should follow:
and thus I think it should be fine. |
The mm_ver is used in GCP marketplace. We can try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Some minor clean up left.
Otherwise
/lgtm
test/release/README.md
Outdated
|
||
Example, release in release branch: | ||
|
||
```bash | ||
TAG=1.4.0 BRANCH=release-1.4 make release | ||
TAG=v.1.4.0 BRANCH=release-1.4 make release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit update
@@ -20,6 +20,12 @@ TAG=$1 | |||
BRANCH=$2 | |||
REPO=kubeflow/pipelines | |||
|
|||
if [[ $TAG != v* ]] ; | |||
then | |||
echo "release tag needs to start with 'v' " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for checking for validity!
/lgtm Thank you for fixing this for go modules! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
I encountered error |
Description of your changes:
Checklist: