Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change release tags to vX.Y.Z. Fixes #5954 #5974

Merged
merged 6 commits into from
Jul 8, 2021

Conversation

NikeNano
Copy link
Member

@NikeNano NikeNano commented Jul 4, 2021

Description of your changes:

Checklist:

@NikeNano NikeNano changed the title [WIP]feat(): tag releases with 'v.'. Fixes #5954 [WIP] feat(): tag releases with 'v.'. Fixes #5954 Jul 4, 2021
@google-cla google-cla bot added the cla: yes label Jul 4, 2021
@NikeNano NikeNano changed the title [WIP] feat(): tag releases with 'v.'. Fixes #5954 [WIP] feat: tag releases with 'v.'. Fixes #5954 Jul 4, 2021
@NikeNano NikeNano changed the title [WIP] feat: tag releases with 'v.'. Fixes #5954 feat: tag releases with 'v.'. Fixes #5954 Jul 4, 2021
@NikeNano
Copy link
Member Author

NikeNano commented Jul 4, 2021

@Bobgy you also mentioned that we might have to update some builds? As I understand the builds will be triggerade baed upon the version in VERSION

@Bobgy
Copy link
Contributor

Bobgy commented Jul 5, 2021

Please search for mm_ver or mm.ver
There are some parsing logic

RELEASE.md Outdated Show resolved Hide resolved
@NikeNano
Copy link
Member Author

NikeNano commented Jul 5, 2021

Please search for mm_ver or mm.ver
There are some parsing logic

Found it:

cat /workspace/VERSION | sed -e "s#\([0-9]\+[.][0-9]\+\)[.].*#\1#" > /workspace/mm.ver

/workspace/test/tag_for_hosted.sh $PROJECT_ID $COMMIT_SHA $(cat /workspace/VERSION) $(cat /workspace/mm.ver)

However I dont think we need to update it:

touch VERSION
echo "v1.7.0-alpha.1" > VERSION
cat VERSION | sed -e "s#\([0-9]\+[.][0-9]\+\)[.].*#\1#"

gives :

v1.7

Where the expected out put should follow:

 # Parse major minor version and save to a file for reusing in other steps.
 # e.g. 1.0.0-rc.1 and 1.0.1 are parsed as 1.0

and thus I think it should be fine.

@Bobgy Bobgy changed the title feat: tag releases with 'v.'. Fixes #5954 feat: tag releases with 'v'. Fixes #5954 Jul 5, 2021
@Bobgy Bobgy changed the title feat: tag releases with 'v'. Fixes #5954 feat: tag releases with vX.Y.Z. Fixes #5954 Jul 5, 2021
@Bobgy
Copy link
Contributor

Bobgy commented Jul 5, 2021

The mm_ver is used in GCP marketplace.
I am not sure whether it supports adding the v prefix.

We can try

Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Some minor clean up left.
Otherwise
/lgtm


Example, release in release branch:

```bash
TAG=1.4.0 BRANCH=release-1.4 make release
TAG=v.1.4.0 BRANCH=release-1.4 make release
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit update

test/release/README.md Outdated Show resolved Hide resolved
@@ -20,6 +20,12 @@ TAG=$1
BRANCH=$2
REPO=kubeflow/pipelines

if [[ $TAG != v* ]] ;
then
echo "release tag needs to start with 'v' "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking for validity!

test/release/release.sh Outdated Show resolved Hide resolved
@Bobgy
Copy link
Contributor

Bobgy commented Jul 8, 2021

/lgtm
/approve

Thank you for fixing this for go modules!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@NikeNano
Copy link
Member Author

NikeNano commented Jul 8, 2021

/retest

@Bobgy Bobgy changed the title feat: tag releases with vX.Y.Z. Fixes #5954 feat: change release tags to vX.Y.Z. Fixes #5954 Jul 8, 2021
@google-oss-robot google-oss-robot merged commit b57bbee into kubeflow:master Jul 8, 2021
@capri-xiyue
Copy link
Contributor

I encountered errorStep #49 - "tagCacheServerForMarketplace": Error parsing reference: "gcr.io/ml-pipeline/google/pipelines/cacheserver:" is not a valid repository/tag: invalid reference format when I tried to make a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants