Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upgrade Minio to newest version with gateway (deprecated) #9658

Closed
wants to merge 2 commits into from

Conversation

koalalorenzo
Copy link

@koalalorenzo koalalorenzo commented Jun 20, 2023

Description of your changes:

Minio's Gateway has been deprecated, but Kubeflow Pipelines is still using an older version that has some bugs. We have encountered plenty of them, and using a newer version of Minio that still includes the gateway functionality fixed most of the errors/issues in pipelines.

This PR upgrades Minio's image provided in Kubeflow manifests.

Checklist:

@google-cla
Copy link

google-cla bot commented Jun 20, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dushyanthsc, gkcalat for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

Hi @koalalorenzo. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@koalalorenzo koalalorenzo force-pushed the master branch 2 times, most recently from 482fb8d to d150e50 Compare June 20, 2023 12:53
Signed-off-by: Lorenzo Setale <lorenzo@setale.me>
Signed-off-by: Lorenzo Setale <lorenzo@setale.me>
@koalalorenzo
Copy link
Author

I had to force-push to make sure that signatures and emails were correct with CLA, sorry about that 🙏

@chensun
Copy link
Member

chensun commented Jun 22, 2023

Hi @koalalorenzo , due the license issue, we cannot upgrade Minio to the latest version.
Please see #7878

@chensun chensun closed this Jun 22, 2023
@harshavardhana
Copy link

harshavardhana commented Nov 30, 2023

So that you all know, sticking to this release has three different security vulnerabilities that are high or critical.

So, anyone running this release would be exposed and vulnerable to these vulnerabilities, potentially causing data loss.

What does it take for Kubeflow to upgrade the MinIO container version? - I can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants