From 3339089aeac598bcccd792ca33c0aaf70ef26711 Mon Sep 17 00:00:00 2001
From: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Date: Fri, 13 Jan 2023 20:55:00 +0000
Subject: [PATCH] Use const for job types

---
 .../kubeflow/training/api/training_client.py  | 22 +++----------------
 1 file changed, 3 insertions(+), 19 deletions(-)

diff --git a/sdk/python/kubeflow/training/api/training_client.py b/sdk/python/kubeflow/training/api/training_client.py
index 8682ada92a..71fc0f93ea 100644
--- a/sdk/python/kubeflow/training/api/training_client.py
+++ b/sdk/python/kubeflow/training/api/training_client.py
@@ -105,25 +105,9 @@ def get_job_conditions(
             RuntimeError: Failed to get Training Job.
         """
 
-        if (
-            job is not None
-            and not isinstance(job, models.KubeflowOrgV1TFJob)
-            and not isinstance(job, models.KubeflowOrgV1PyTorchJob)
-            and not isinstance(job, models.KubeflowOrgV1MXJob)
-            and not isinstance(job, models.KubeflowOrgV1XGBoostJob)
-            and not isinstance(job, models.KubeflowOrgV1MPIJob)
-            and not isinstance(job, models.KubeflowOrgV1PaddleJob)
-        ):
-            raise ValueError(
-                "Job must be one of these types: {},{},{},{},{},{}".format(
-                    models.KubeflowOrgV1TFJob,
-                    models.KubeflowOrgV1PyTorchJob,
-                    models.KubeflowOrgV1MXJob,
-                    models.KubeflowOrgV1XGBoostJob,
-                    models.KubeflowOrgV1MPIJob,
-                    models.KubeflowOrgV1PaddleJob,
-                )
-            )
+        models = tuple([d["model"] for d in list(constants.JOB_KINDS.values())])
+        if job is not None and not isinstance(job, models):
+            raise ValueError(f"Job must be one of these types: {models}")
 
         # If Job is not set, get the Training Job.
         if job is None: