Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to remove older tensorflow controller related files from repo #1367

Closed
deepak-muley opened this issue Aug 17, 2021 · 9 comments
Closed
Assignees

Comments

@deepak-muley
Copy link
Contributor

In order to keep the controller folder consistent across all frameworks, only "frameworkjob_controller.go", "framework.go" and "suit_test.go" are the used files.
tf-operator/pkg/controller.v1/tensorflow has files from previous controller code which needs to be removed.

@gaocegege
Copy link
Member

SGTM

@deepak-muley
Copy link
Contributor Author

@thunderboltsid is interested in working on this as his first issue. we can take it up in the next release as we are close to this release. @Jeffwan

@Jeffwan
Copy link
Member

Jeffwan commented Aug 17, 2021

/assign @thunderboltsid

@google-oss-robot
Copy link

@Jeffwan: GitHub didn't allow me to assign the following users: thunderboltsid.

Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @thunderboltsid

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jeffwan
Copy link
Member

Jeffwan commented Aug 17, 2021

@thunderboltsid please type /assign if you want to pick it up

@thunderboltsid
Copy link
Contributor

/assign

@deepak-muley
Copy link
Contributor Author

we should also remove cmd/tf-operator.v1 as we already have cmd/training-operator.v1 folder

@thunderboltsid
Copy link
Contributor

thunderboltsid commented Aug 27, 2021

@Jeffwan @deepak-muley can we close this issue now? or is there something more that needs to be done?

@Jeffwan
Copy link
Member

Jeffwan commented Aug 29, 2021

@thunderboltsid I think so. Thanks for the contribution

@Jeffwan Jeffwan closed this as completed Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants