-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to remove older tensorflow controller related files from repo #1367
Comments
SGTM |
@thunderboltsid is interested in working on this as his first issue. we can take it up in the next release as we are close to this release. @Jeffwan |
/assign @thunderboltsid |
@Jeffwan: GitHub didn't allow me to assign the following users: thunderboltsid. Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@thunderboltsid please type |
/assign |
we should also remove cmd/tf-operator.v1 as we already have cmd/training-operator.v1 folder |
@Jeffwan @deepak-muley can we close this issue now? or is there something more that needs to be done? |
@thunderboltsid I think so. Thanks for the contribution |
In order to keep the controller folder consistent across all frameworks, only "frameworkjob_controller.go", "framework.go" and "suit_test.go" are the used files.
tf-operator/pkg/controller.v1/tensorflow has files from previous controller code which needs to be removed.
The text was updated successfully, but these errors were encountered: