-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Webhook Validation #1993
Comments
/assign |
I'm wondering if we should not implement the webhook validations for the MXJob because we will remove the MXJob. @kubeflow/wg-training-leads WDYT? |
Based on the last community call, we decided not to implement webhook validations for MXJob, but we will implement webhook warnings to notify deprecations. |
Yes, that's correct @tenzen-y! |
@andreyvelich @johnugeorge For MPIJob v1, I'm wondering if we can skip to implement webhooks. |
I am fine to not add them since we will be focus on V2 for the long-term |
Thank you for checking this. |
As described in #1708 (comment), we can not introduce CEL validations for fields under the
.spec.replicaSpec
due to the CEL cost budget violations. The root cause is that ourreplicaSpec
is defined as a typedmap
, and then Kubernetes can not estimate how many maximum replicas will be held in the.spec.replicas
.Also, current validations aren't better for UX since the users can find validation errors only in the training-operator logs.
So, I would suggest introducing the webhook validations with internal certs mechanisms like Katib since validations help to find validation errors for users and the internal cert mechanisms could reduce installation costs.
/kind feature
The text was updated successfully, but these errors were encountered: