Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-2170: Add APIs for TrainJob and TrainingRuntime #2206

Closed
andreyvelich opened this issue Aug 14, 2024 · 2 comments · Fixed by #2221, #2223 or #2222
Closed

KEP-2170: Add APIs for TrainJob and TrainingRuntime #2206

andreyvelich opened this issue Aug 14, 2024 · 2 comments · Fixed by #2221, #2223 or #2222
Assignees
Labels

Comments

@andreyvelich
Copy link
Member

andreyvelich commented Aug 14, 2024

Related: #2170.

We should add APIs for TrainJob, TrainingRuntime, ClusterTrainingRuntime.

The directory structure that we want to follow:

/cmd/training-operator.v2alpha1/Dockerfile
/cmd/training-operator.v2alpha1/main.go

/pkg/apis/kubeflow.org/v2alpha1
/pkg/controller.v2/trainjob_controller.go

/pkg/webhooks/trainjob_webhook.go

/assign @andreyvelich
/area api

@tenzen-y
Copy link
Member

Could you separate the PR to create skeleton v2 manager and API changes since it is better to define APIs in the dedicated PR for easy tracking?

1st issue and PR is responsible for setting up skeleton v2 manager.

  • /cmd/training-operator.v2alpha1/Dockerfile
  • /cmd/training-operator.v2alpha1/main.go

2nd issue and PR is responsible for adding APis.

  • /pkg/apis/kubeflow.org/v2alpha1

Regarding the below implementations should be treated as other issues:

  • /pkg/controller.v2/trainjob_controller.go
  • /pkg/webhooks/trainjob_webhook.go

@andreyvelich
Copy link
Member Author

Could you separate the PR to create skeleton v2 manager and API changes since it is better to define APIs in the dedicated PR for easy tracking?

1st issue and PR is responsible for setting up skeleton v2 manager.

  • /cmd/training-operator.v2alpha1/Dockerfile
  • /cmd/training-operator.v2alpha1/main.go

2nd issue and PR is responsible for adding APis.

  • /pkg/apis/kubeflow.org/v2alpha1

Regarding the below implementations should be treated as other issues:

  • /pkg/controller.v2/trainjob_controller.go
  • /pkg/webhooks/trainjob_webhook.go

Sure, that makes sense! Will do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment