Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-2170: Implement validations for TrainJob #2209

Open
Tracked by #2170
andreyvelich opened this issue Aug 14, 2024 · 6 comments
Open
Tracked by #2170

KEP-2170: Implement validations for TrainJob #2209

andreyvelich opened this issue Aug 14, 2024 · 6 comments
Assignees
@akshaychitneni
Labels
area/webhook

Comments

@andreyvelich
Copy link
Member

andreyvelich commented Aug 14, 2024 •
edited by tenzen-y
Loading

Related: #2170

We should create validations for the TrainJob using the following tools:

  • Mutating Webhooks
  • CEL validations
  • controller-tools/kubebuilder annotations

/area webhook
@tenzen-y tenzen-y changed the title KEP-2170: Create validation webhook for TrainJob KEP-2170: Create validations for TrainJob Aug 16, 2024
@tenzen-y
Copy link
Member

/retitle KEP-2170: Implement validations for TrainJob

@tenzen-y tenzen-y changed the title KEP-2170: Create validations for TrainJob KEP-2170: Implement validations for TrainJob Aug 16, 2024
@tenzen-y tenzen-y mentioned this issue Aug 16, 2024
Merged
@tenzen-y
Copy link
Member

Regarding to CEL validations. We can refer the following Kubernetes blog on how we can implement the CEL validations using kubebuilder markers.

https://kubernetes.io/blog/2022/09/29/enforce-immutability-using-cel/

@andreyvelich andreyvelich mentioned this issue Aug 28, 2024
Open
18 tasks
@tenzen-y tenzen-y mentioned this issue Sep 6, 2024
Merged
1 task
@akshaychitneni
Copy link
Contributor

/assign

@akshaychitneni akshaychitneni mentioned this issue Sep 16, 2024
Merged
@tenzen-y
Copy link
Member

@akshaychitneni What are the remaining implementations in this issue?
You assume only webhook validations?

@akshaychitneni
Copy link
Contributor

Yes. I am working on the webhook validations

@tenzen-y
Copy link
Member

Yes. I am working on the webhook validations

Thank you. Let me know once you finalize it.

@akshaychitneni akshaychitneni mentioned this issue Oct 25, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akshaychitneni akshaychitneni

Labels
area/webhook
Projects
KEP-2170: Kubeflow Training V2 API
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akshaychitneni @andreyvelich @tenzen-y