Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 1.4.1 release #154

Closed
5 of 6 tasks
dholbach opened this issue Jun 29, 2020 · 7 comments
Closed
5 of 6 tasks

Create 1.4.1 release #154

dholbach opened this issue Jun 29, 2020 · 7 comments
Assignees

Comments

@dholbach
Copy link
Member

dholbach commented Jun 29, 2020

Release

  • Smoke-test on current k8s 1.16, 1.17, 1.18
  • Test in Weave dev environment
  • Test helm things?
  • Write release notes
  • Release
  • Announce

Post release

Deal with rest of #140

@dholbach
Copy link
Member Author

Tested on minikube with k8s 1.16.12, 1.17.8, 1.18.5.

@dholbach dholbach self-assigned this Jun 29, 2020
@dholbach
Copy link
Member Author

@ckotzbauer Anything from a Helm POV you want to test before releasing 1.4.1?

@dholbach
Copy link
Member Author

Release notes could be something like:


This release adds to the previous 1.4.0 release

Features

kured Helm chart

We intend to take over the kured chart from helm/charts/stable. Please consult https://github.com/weaveworks/kured/tree/master/charts/kured for upgrading from the previous chart.

Thanks a lot everyone who helped with this release, in particular @bboreham, @ckotzbauer, @dholbach, @michalschott and others who helped with testing!

Kubernetes Version Compatibility

The daemon image contains a 1.17.x k8s.io/client-go and kubectl binary for the purposes of maintaining the lock and draining worker nodes. Kubernetes aims to provide forwards & backwards compatibility of one minor version between client and server, so this should work on 1.1[678].x.

Tested in minikube on 1.16.12, 1.17.8, 1.18.5.


@ckotzbauer
Copy link
Member

@dholbach No, there's nothing to test before the release. It can be tested finally, if the release is done.
I noticed that for every release we have to update those places in the chart with the release we want to publish:

  • Chart.yaml (appVersion)
  • values.yaml (image.tag)
  • Readme (image.tag default-value)

Maybe there's a better way in the future to automate this...

@dholbach
Copy link
Member Author

Ok, so we need to update those values first, and maybe the main README too?

@ckotzbauer
Copy link
Member

Yes, otherwise we always release a chart with the previous version of kured. 😂
Should I do a quick PR for those changes?
What would you change in the main README?

@dholbach
Copy link
Member Author

#157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants