Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block IPVS on 1.23 clusters running Canal/Calico CNI #1695

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Dec 17, 2021

What this PR does / why we need it:

Canal and Calico VXLAN CNIs are not working when kube-proxy is used in the IPVS mode. This is a known issue and more details can be found here: projectcalico/calico#5011

Because of that, this PR adds validation to reject IPVS on Kubernetes 1.23 clusters using Canal or Calico VXLAN addon.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #1670

Does this PR introduce a user-facing change?:

Block IPVS on 1.23 clusters running Canal/Calico CNI

/assign @kron4eg

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Dec 17, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii xmudrii requested a review from kron4eg December 17, 2021 11:49
@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 17, 2021
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b616cbf47ba9caf799a98898c8a68e51e1643cd7

@kubermatic-bot kubermatic-bot merged commit 07690d2 into master Dec 17, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.4 milestone Dec 17, 2021
@kubermatic-bot kubermatic-bot deleted the block-ipvs-1.23 branch December 17, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants