Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kubevirt): configure runStrategy #1821

Open
oliverbaehler opened this issue Jul 5, 2024 · 0 comments
Open

feat(kubevirt): configure runStrategy #1821

oliverbaehler opened this issue Jul 5, 2024 · 0 comments

Comments

@oliverbaehler
Copy link

Hi. more like a question:

Is there a specific reason this is hard-coded to RunOnce for the kubevirt probvider?

RunStrategy: &runStrategyOnce,

There's other strategies available: https://pkg.go.dev/kubevirt.io/api/core/v1#VirtualMachineRunStrategy

I guess it makes sense as default, but consider this: If a kubevirt host dives (restarts) all the kubermatic VMIs do not restart (unless you live-migrate to another host, if there's another available). Would it be possible to make this field configurable via machineTemplate? The default can still be RunOnce, but eg. in our use-case we would prefer to use RerunOnFailure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant