Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quantity.java is missing an equals method #343

Closed
saskiawagenaar opened this issue Aug 21, 2018 · 2 comments
Closed

Quantity.java is missing an equals method #343

saskiawagenaar opened this issue Aug 21, 2018 · 2 comments

Comments

@saskiawagenaar
Copy link
Contributor

kubernetes/src/main/java/io/kubernetes/client/custom/Quantity.java has no implemented equals method, which makes it difficult to compare deployments which have resource limits or requests.
@saskiawagenaar saskiawagenaar mentioned this issue Aug 21, 2018
Merged
@brendandburns
Copy link
Contributor

Closed by #344

@nulls nulls mentioned this issue Jun 17, 2024
Open
@orchestr7
Copy link

You must override hashCode() in every class that overrides equals(). Failure to do so will result in a violation of the general contract for Object.hashCode(), which will prevent your class from functioning properly in conjunction with all hash-based collections, including HashMap, HashSet, and Hashtable.

(c) Joshua Bloch || Effective Java 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brendandburns @saskiawagenaar @orchestr7