-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crd-model-gen:v1.0.6 hasn't been updated in three years #3712
Comments
You can always regenerate the image as needed using the script here: and the Dockerfile here: We'd welcome a PR updating the version of kind that is used. Most people don't need to use this script unless they are generating their own CRD code. |
@brendandburns Thanks for the quick reply.
I must be misunderstanding, as I surely don't have push permissions to that container repo. Or git tags in this repo.
I'd be glad to bump this to a
We are using this workflow so that java clients can interact with golang controllers. (CRD yaml is generated from golang structs) |
Oh it seems that HEAD is currently meant to use KiND As for publishing a new image, I found two scripts, neither of which seem to ever run. (one is hard-coded to https://github.com/kubernetes-client/java/blob/master/scripts/publish-crd-model-gen-image.sh |
You can push the image to your own registry and then modify the workflow that you referenced to point to your image, instead of the ghcr one. If you want to add this parameterization to those scripts, we'd be happy to take those PRs. |
Much obliged. Parametrization proposed per pull petition #3716 |
Describe the bug
The container
ghcr.io/kubernetes-client/java/crd-model-gen:v1.0.6
is 3 years old and makes use of a similarly aged KiND version, v0.11.1. Some security tools are flagging these old files as vulnerable. e.g.Continuing to use this for java codegen may become impossible in environments where I cannot control what security scans run or their strictness.
The text was updated successfully, but these errors were encountered: