From d17707d4d2c1e6846452133ed3f4e80fdeaeb2d2 Mon Sep 17 00:00:00 2001 From: Brendan Burns Date: Wed, 20 Nov 2024 22:35:28 -0600 Subject: [PATCH] Address comment --- src/web-socket-handler.ts | 3 --- src/web-socket-handler_test.ts | 4 ++-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/web-socket-handler.ts b/src/web-socket-handler.ts index 064df5b1ce..31d2332823 100644 --- a/src/web-socket-handler.ts +++ b/src/web-socket-handler.ts @@ -42,13 +42,11 @@ export class WebSocketHandler implements WebSocketInterface { } public static closeStream(streamNum: number, streams: StreamInterface): void { - console.log('Closing stream: ' + streamNum); switch (streamNum) { case WebSocketHandler.StdinStream: streams.stdin.pause(); break; case WebSocketHandler.StdoutStream: - console.log('closing stdout'); streams.stdout.end(); break; case WebSocketHandler.StderrStream: @@ -249,7 +247,6 @@ export class WebSocketHandler implements WebSocketInterface { } else if (data instanceof Buffer) { const streamNum = data.readUint8(0); if (streamNum === WebSocketHandler.CloseStream) { - console.log('Closing stream!'); WebSocketHandler.closeStream(data.readInt8(1), this.streams); } if (binaryHandler && !binaryHandler(streamNum, data.subarray(1))) { diff --git a/src/web-socket-handler_test.ts b/src/web-socket-handler_test.ts index 54d7de65bf..9827feba1a 100644 --- a/src/web-socket-handler_test.ts +++ b/src/web-socket-handler_test.ts @@ -2,7 +2,7 @@ import { promisify } from 'util'; import { expect } from 'chai'; import WebSocket = require('isomorphic-ws'); import { ReadableStreamBuffer, WritableStreamBuffer } from 'stream-buffers'; -import stream = require('stream'); +import stream from 'node:stream'; import { V1Status } from './api'; import { KubeConfig } from './config'; @@ -401,7 +401,7 @@ describe('V5 protocol support', () => { stdinStream.emit('end'); expect(sent).to.not.be.null; expect(sent!.readUint8(0)).to.equal(255); // CLOSE signal - expect(sent!.readUInt8(1)).to.equal(0); // Stdin stream is #0 + expect(sent!.readUint8(1)).to.equal(0); // Stdin stream is #0 }); });