Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated npm request dependency #1031

Closed
WassimBenzarti opened this issue Mar 29, 2023 · 2 comments
Closed

Remove deprecated npm request dependency #1031

WassimBenzarti opened this issue Mar 29, 2023 · 2 comments

Comments

@WassimBenzarti
Copy link

WassimBenzarti commented Mar 29, 2023

Describe the bug
There is a vulnerability related to request npm package which is a dependency of @kubernetes/client-node. Here’s the npm audit report:

# npm audit report

request  *
Severity: moderate
Server-Side Request Forgery in Request - https://github.com/advisories/GHSA-p8p7-x288-28g6
No fix available
node_modules/request
  @kubernetes/client-node  *
  Depends on vulnerable versions of request
  node_modules/@kubernetes/client-node

2 moderate severity vulnerabilities

Some issues need review, and may require choosing
a different dependency.

Unfortunately, the GitHub repository is not currently maintained and there are no maintainers who could merge this PR.

Is there any chance we can remove the request dependency since it’s deprecated since February 2020.

@mstruebing
Copy link
Member

This is currently work in progress and the current state is in the release-1.x branch.
There is a tag published in the current state but I think it's not yet officially supported and doesn't include all features:
1.0.0-rc1

@brendandburns
Copy link
Contributor

Closing this as a duplicate of #1020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants