Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit an event when the informer reconnects the watch feed #609

Closed
dominykas opened this issue Mar 17, 2021 · 1 comment · Fixed by #614
Closed

Emit an event when the informer reconnects the watch feed #609

dominykas opened this issue Mar 17, 2021 · 1 comment · Fixed by #614

Comments

@dominykas
Copy link
Contributor

dominykas commented Mar 17, 2021

My primary use case for this is just logging - there's an issue #596 about the watcher silently stopping and this might help debug the problem.

We're already operating a controller written in Node.js, and we've spotted similar issues - having some logs around the reconnection (and having them missing when things go south) has helped in trying to at
least determine a rough range of time when the problems started occurring (fwiw - it seems to be related to master node rotation, although not easily reproducible).

It would be nice if Informer was able to emit something like connected each time it restarts the watcher?

@brendandburns
Copy link
Contributor

Sure. One other thing that we should probably do is add Prometheus metrics so that you can monitor them in addition to monitoring the logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants