-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencie net-keepalive does not support win32 #632
Comments
@bacongobbler @brendandburns This was caused by #630 |
Hey thanks for reaching out. Good catch with this one. I wonder if it is possible to selectively disable the tcp keepalive probe header on non-unix systems, as that's how Go provides this functionality to client-go. From https://golang.org/pkg/net/ (emphasis bold):
I don't have enough typescript chops to do this myself, but that's how I'd proceed here. |
Alternatively, it does appear the net-keepalive maintainers are welcome to PRs to provide windows support. So another option would be to perform a no-op pointing to Go's pkg/net implementation as reference. https://github.com/hertzg/node-net-keepalive
|
I'm seeing an error on Linux as well:
|
Hello, I am also seeing this issue with net-keepalive not supporting win64. I was just able to install v0.14.0. Is there a later version that I can use in the meantime where net-keepalive should still work? Thanks for your help. EDIT: v0.14.1 installed fine as well. v0.14.2 seems to be the first problem version. |
net-Keepalive was introduced in version 0.14.2. Point to version 0.14.1 and you can use it normally |
Thanks for the report. We'll look into fixing this shortly. In the meantime release |
Can y’all give #635 a shot and let me know if that fixes the issue for you? |
Everything seems to have installed just fine, and from my preliminary testing, I'm getting good responses from the API. Thanks so much for the quick fix! |
Describe the bug
Dependencie
net-keepalive
does not support win32Client Version
0.14.2
To Reproduce
In Windows:
yarn add @kubernetes/client-node
Expected behavior
Package successfully add
Current behavior
![image](https://user-images.githubusercontent.com/1816859/114062596-11f49c00-986e-11eb-98b6-79cb63c62abe.png)
Error on fetching packages
The text was updated successfully, but these errors were encountered: