Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry for transient faults #96

Closed
jeehwancho opened this issue Aug 31, 2018 · 1 comment
Closed

Retry for transient faults #96

jeehwancho opened this issue Aug 31, 2018 · 1 comment

Comments

@jeehwancho
Copy link

Is it supposed to handle transient faults like 504 by retrying, or have users handle?
It seems to me the fix could be as simple as using one of request wrappers like node-request-retry in place of request, for example.
Any thoughts would be appreciated.

@brendandburns
Copy link
Contributor

They are left for the user to handle. The original code is generated from the Swagger Codegen project, so if you wanted to add that retry library, that would be the right place to add it (unless you can figure out a way to add it into this library w/o modifying the generated code in api.ts)

PRs welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants