-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raise ConfigException
on invalid named-arguments to load_incluster_config
#2204
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @addyess! |
/kind bug |
/assign @yliaog |
""" | ||
Use the service account kubernetes gives to pods to connect to kubernetes | ||
cluster. It's intended for clients that expect to be running inside a pod | ||
running on kubernetes. It will raise an exception if called from a process | ||
not running in a kubernetes environment.""" | ||
for val in kds.values(): | ||
if val is not None: | ||
raise ConfigException(f"Unimplemented named-argument {val} for incluster config.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is ConfigException better than TypeError ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its only slightly better because the client code only has to catch one exception -- ConfigException
Secondarily, this will allow callers to: load_config
to call with a keyword arg like context=None
and load_incluster_config
won't bark with the TypeError
, but if there is a context=<val>
that's non-none, we'll get a meaningful exceptions from load_incluster_config
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: addyess The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
/kind api-change
What this PR does / why we need it:
Gracefully ignore named-arguments to
load_incluster_config
which have a value ofNone
Which issue(s) this PR fixes:
Fixes #2203
Special notes for your reviewer:
I couldn't find any unit tests for calling
load_incluster_config
directly. Let me know if i should add some.Does this PR introduce a user-facing change?
No, it should be transparent. The exception changes from a TypeError to ConfigException
Before:
to