Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove forceUmount and lazyUmount #582

Merged
merged 1 commit into from
Feb 19, 2023

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Feb 18, 2023

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: remove forceUmount and lazyUmount
This PR is reverting https://github.com/kubernetes-sigs/azurefile-csi-driver/pull/569since “umount -f -l” (linux force umount & lazy umount) would make the smb mount dir broken(pointing to an invalid device) when there is heavy read write on the smb mount dir to be unmounted.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

fix: remove forceUmount and lazyUmount

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4210344614

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 85.744%

Totals Coverage Status
Change from base Build 4209056675: 0.9%
Covered Lines: 812
Relevant Lines: 947

💛 - Coveralls

@andyzhangx andyzhangx merged commit d40bdb9 into kubernetes-csi:master Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants