Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add default krb5 cc path #613

Merged
merged 1 commit into from
May 13, 2023

Conversation

edward2a
Copy link
Contributor

Upon running master branch the following error was showing:

    May 11 10:19:42 worker-02 cifs.upcall: get_existing_cc: default ccache is FILE:/tmp/krb5cc_0

Checked on the host and the configuration was appropriate, mounting a cifs share did work approrpiately.

This error was showing specifically inside the smb container, so adding the configuration for the default krb5 cc path as expected by this sci.

What type of PR is this?
/kind bug

What this PR does / why we need it:
Added default krb5.conf to the Dockerfile in cmd/smbplugin/Dockerfile with content:

[libdefaults]
	default_ccache_name = FILE:/var/lib/kubelet/kerberos/krb5cc_%{uid}

Which issue(s) this PR fixes: #612

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

Added default krb5.conf to look up krb5cc in /var/lib/kubelet/kerberos

Upon running master branch the following error was showing:

        May 11 10:19:42 worker-02 cifs.upcall: get_existing_cc: default ccache is FILE:/tmp/krb5cc_0

Checked on the host and the configuration was appropriate, mounting a
cifs share did work approrpiately.

This error was showing specifically inside the smb container, so adding
the configuration for the default krb5 cc path as expected by this sci.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels May 11, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 11, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: edward2a / name: Eduardo (fc14f86)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 11, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @edward2a!

It looks like this is your first PR to kubernetes-csi/csi-driver-smb 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-smb has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 11, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @edward2a. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 11, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 11, 2023
@edward2a edward2a changed the title Add default krb5 cc path fix: add default krb5 cc path May 11, 2023
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 12, 2023
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, edward2a

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit d714702 into kubernetes-csi:master May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants