Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: customize kerberos settings #709

Merged
merged 1 commit into from
Dec 15, 2023
Merged

feat: customize kerberos settings #709

merged 1 commit into from
Dec 15, 2023

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: customize kerberos settings

Which issue(s) this PR fixes:

Fixes #705

Requirements:

Special notes for your reviewer:

Release note:

feat: customize kerberos settings

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7210130534

  • 13 of 18 (72.22%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 80.052%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/smb/nodeserver.go 11 16 68.75%
Totals Coverage Status
Change from base Build 7203845627: 0.03%
Covered Lines: 915
Relevant Lines: 1143
💛 - Coveralls

@andyzhangx andyzhangx mentioned this pull request Dec 14, 2023
Closed
@andyzhangx andyzhangx merged commit 4a84e51 into kubernetes-csi:master Dec 15, 2023
20 of 21 checks passed
@dfajmon dfajmon mentioned this pull request Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

microk8s + kerberos integration issues
3 participants
@andyzhangx @k8s-ci-robot @coveralls