Added support for tolerations in local-volume provisioner daemonset helm template

[dubuc]

Added support for tolerations in the DaemonsSet Helm template for the static local volume provisioner.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[dubuc]

/area local-volume
/assign @msau42

[msau42]

cc @cofyc

[cofyc]

This makes sense to me. Could you wait a while? There are some refactorings in #789, you can make changes based on new helm chart values/template files after that pr is merged.

[cofyc]

Because toleration is a spec of kubernetes api, add a reference to its docs should be enough.

  # Node tolerations for local-volume-provisioner scheduling to nodes with taints.
  # Ref: https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/
  tolerations: []

[dubuc]

Thank you for that input, it does make more sense :) Fixed.

[dubuc]

Yes no worries, I manually packaged a chart in the meantime. :) I can refactor a little after your updates. Thanks for the feedback.

[cofyc]

@dubuc #789 has been merged, please rebase on latest master.
btw please also

• add a example in helm/examples (and also added a expected yaml file in helm/test/expected, test it with helm/test/run.sh script)
• update helm/README.md configurations section

[dubuc]

@cofyc Hi! Sorry for the delay, but was quite busy the past few weeks. I've amended the PR to reflect the changes required. Thanks for the work you did with the tests and documentation! :) 👍 Please let me know if something else is required.

[msau42]

/lgtm
Thanks!

[msau42]

@dubuc I had a follow up question on this. In your example, you are tolerating a master node. Does that mean you want to expose the local disks on your master node and also have workload pods scheduled to the master node?