Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imports point to old repository? #1

Open
snowch opened this issue Feb 19, 2020 · 1 comment
Open

Imports point to old repository? #1

snowch opened this issue Feb 19, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@snowch
Copy link

snowch commented Feb 19, 2020

Are these imports correct?

https://github.com/kubernetes-operators-book/chapters/blob/master/ch07/visitors-operator/cmd/manager/main.go#L13-L14

@snowch snowch changed the title Imports in ch07/visitors-operator/cmd/manager/main.go point to old repository? Imports point to old repository? Feb 19, 2020
@joshix
Copy link
Contributor

joshix commented Jun 30, 2022

The identical imports remain in place at that older repo, viz: https://github.com/jdob/visitors-operator/tree/master/pkg, so this remains functional (which sort of adds to the confusion). Nevertheless you are correct and the import should probably be:
github.com/kubernetes-operators-book/chapters/ch07/visitors-operator/pkg/^(apis controller)

@joshix joshix added the bug Something isn't working label Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants