Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

Fix jsonpatch in go.sum #58

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

ncdc
Copy link
Contributor

@ncdc ncdc commented Aug 1, 2019

What this PR does / why we need it:
This should fix issues encountered when working with go modules, GOPROXY, and jsonpatch.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
I edited hack/update-deps.sh and added GOPROXY=https://proxy.golang.org

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

@k8s-ci-robot
Copy link
Contributor

Welcome @ncdc!

It looks like this is your first PR to kubernetes-sigs/cluster-api-bootstrap-provider-kubeadm 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-bootstrap-provider-kubeadm has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 1, 2019
@k8s-ci-robot k8s-ci-robot requested review from chuckha and detiber August 1, 2019 01:14
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 1, 2019
@ncdc
Copy link
Contributor Author

ncdc commented Aug 1, 2019

/assign @chuckha @detiber

@ncdc
Copy link
Contributor Author

ncdc commented Aug 1, 2019

@cblecker @BenTheElder is this the right thing to do?

@ncdc
Copy link
Contributor Author

ncdc commented Aug 1, 2019

/hold
pending discussions in kubernetes-sigs/cluster-api#1217

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2019
Signed-off-by: Andy Goldstein <goldsteina@vmware.com>
@ncdc ncdc force-pushed the fix-jsonpatch-go-mod branch from eb5522e to 8015866 Compare August 1, 2019 14:02
@ncdc
Copy link
Contributor Author

ncdc commented Aug 1, 2019

I've updated the CAPI PR and it's in the merge queue.

/hold cancel
/assign @detiber

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2019
@detiber
Copy link
Contributor

detiber commented Aug 1, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2019
@ncdc
Copy link
Contributor Author

ncdc commented Aug 1, 2019

Needs approval too - thanks!

@detiber
Copy link
Contributor

detiber commented Aug 1, 2019

oops 😂
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber, ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2019
@k8s-ci-robot k8s-ci-robot merged commit b2f8ed4 into kubernetes-retired:master Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants