Skip to content
This repository has been archived by the owner on Mar 26, 2021. It is now read-only.

Add crinit aggregated unit tests #114

Closed
font opened this issue Dec 1, 2017 · 4 comments
Closed

Add crinit aggregated unit tests #114

font opened this issue Dec 1, 2017 · 4 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster.
Milestone
v0.1 (Beta)

Comments

@font
Copy link
Contributor

font commented Dec 1, 2017

Add crinit aggregated unit tests similar to standalone_test.go. This could also include refactoring the common unit test code.

/sig multicluster
@k8s-ci-robot k8s-ci-robot added the sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. label Dec 1, 2017
@perotinus perotinus added this to the v0.2 (Beta) milestone Dec 5, 2017
@font
Copy link
Contributor Author

font commented Jan 5, 2018

/help

@k8s-ci-robot
Copy link
Contributor

@font:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jan 5, 2018
@onyiny-ang onyiny-ang mentioned this issue Jan 9, 2018
Merged
@onyiny-ang
Copy link
Contributor

@font @perotinus Has this issue been sufficiently addressed by #170 or is there additional functionality that I can work on to close out this issue? I'm looking for some more work and am wondering if this might be a good place to start (again).

@onyiny-ang onyiny-ang mentioned this issue Feb 28, 2018
Merged
@perotinus
Copy link
Contributor

Note that this issue is no longer applicable because of the CRD migration done in #225, which removes crinit and the standalone API server.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster.
Projects
None yet
Milestone
v0.1 (Beta)
Development

No branches or pull requests
4 participants
@font @perotinus @onyiny-ang @k8s-ci-robot