Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

Federated workloads' status is not updated with availableReplicas/readyReplicas #1240

Closed
pacoxu opened this issue Jun 30, 2020 · 13 comments
Closed
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@pacoxu
Copy link
Contributor

pacoxu commented Jun 30, 2020

What would you like to be added:

Current status of FederatedDeployment

  status:
    clusters:
    - name: paco81
    - name: cluster0
    conditions:
    - lastTransitionTime: "2020-06-30T02:23:45Z"
      lastUpdateTime: "2020-06-30T02:42:22Z"
      status: "True"
      type: Propagation
    observedGeneration: 2

Deployment status

  status:
    availableReplicas: 1
    conditions:
    - lastTransitionTime: "2020-06-28T08:54:27Z"
      lastUpdateTime: "2020-06-28T08:54:36Z"
      message: ReplicaSet "python2-5qnzb-deployment-67ddd6c4b6" has successfully progressed.
      reason: NewReplicaSetAvailable
      status: "True"
      type: Progressing
    - lastTransitionTime: "2020-06-28T10:13:23Z"
      lastUpdateTime: "2020-06-28T10:13:23Z"
      message: Deployment has minimum availability.
      reason: MinimumReplicasAvailable
      status: "True"
      type: Available
    observedGeneration: 1
    readyReplicas: 1
    replicas: 1
    updatedReplicas: 1

The expected status of federated deployment is something like.

  status:
    clusters:
    - name: paco81
      availableReplicas: 1
      readyReplicas: 1
      replicas: 1
      updatedReplicas: 1
    - name: cluster0
      availableReplicas: 1
      observedGeneration: 1
      readyReplicas: 1
      replicas: 1
      updatedReplicas: 1
    conditions:
    - lastTransitionTime: "2020-06-30T02:23:45Z"
      lastUpdateTime: "2020-06-30T02:42:22Z"
      status: "True"
      type: Propagation
    observedGeneration: 2

Why is this needed:
In federated resource aspect, we can see READY instances number and available instances numbers like deployment.

[root@dce-10-7-177-8 .kube]# kubectl get deployment
NAME                              READY   UP-TO-DATE   AVAILABLE   AGE
cloudevents-go-7nvpc-deployment   1/1     1            1           23h
dao-2048-dao-2048                 1/1     1            1           24h

For workloads like deployment/replicasets/statefulsets/daemonset, the status of each cluster would be shown in federated instances.

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 30, 2020
@RainbowMango
Copy link
Contributor

@pacoxu Thanks, I'm glad to hear from you.
We are discussing how to add generic status for all kinds of federated resources at #1237. You are welcome to join in.

In my opinion, your request is totally reasonable, let's see how to accomplish it.

@pacoxu
Copy link
Contributor Author

pacoxu commented Jun 30, 2020

From federated deployment controller side, this status would help a lot in rebalance scenario like below.

image

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 28, 2020
@hectorj2f
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 28, 2020
@hectorj2f
Copy link
Contributor

/assign @hectorj2f

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 27, 2020
@hectorj2f
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 27, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 27, 2021
@pacoxu
Copy link
Contributor Author

pacoxu commented Mar 29, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 29, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 27, 2021
@k8s-triage-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 27, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

6 participants