Compute NumPropagatedObjects in HNCConfiguration status

[sophieliu15]

This PR computes NumPropagatedObjects as a part of HNCConfiguration status. NumPropagatedObjects indicates the number of propagated objects of a specific type created by HNC.

Tested:unit tests, GKE cluster

Issue: #411

[sophieliu15]

/assign @adrianludwin
/assign @yiqigao217

[adrianludwin]

Nice! Circling back to review the tests now but I wanted to send you what I already had.

[adrianludwin]

Eh, now I see the downside to putting the Sleep at the beginning of the Reconciler - it means that the regular business logic (e.g. adding/removing types) is also delayed by 3s. I'm not sure we want that. Sorry I missed that.

How about we write some logic to intercept the calls from the object reconcilers and make sure we only trigger one reconciliation every N seconds? That way, most of the reconciler will still work ASAP. You'll have to write the deduping logic yourself but that should be pretty simple. Talk to Yiqi about how to trigger a periodic event using a long-running goroutine. It'll look something like this in the Setup function:

go func() {
  for { // have some kind of way to break the loop when the controller exits
    time.Sleep(3 * time.Second) // use constant instead
    if r.objCountChanged {
      r.objCountChanged = false
      r.enqueueReconcile()
    }
  }
}()

[sophieliu15]

Eh, now I see the downside to putting the Sleep at the beginning of the Reconciler - it means that the regular business logic (e.g. adding/removing types) is also delayed by 3s. I'm not sure we want that. Sorry I missed that.

How about we write some logic to intercept the calls from the object reconcilers and make sure we only trigger one reconciliation every N seconds? That way, most of the reconciler will still work ASAP. You'll have to write the deduping logic yourself but that should be pretty simple. Talk to Yiqi about how to trigger a periodic event using a long-running goroutine. It'll look something like this in the Setup function:

go func() {
  for { // have some kind of way to break the loop when the controller exits
    time.Sleep(3 * time.Second) // use constant instead
    if r.objCountChanged {
      r.objCountChanged = false
      r.enqueueReconcile()
    }
  }
}()

Thanks for the suggestion! I will resolve the comments about tests later after I change to this method. Hopefully it won't take that long after.

[sophieliu15]

Hi @adrianludwin

Thanks so much for the review. I updated the code and replied to all your comments. Feel free to take a look!

Thank you!

[adrianludwin]

Sorry for the terse comments, just trying to get this back to you ASAP. Almost ready to go, just a few last comments

[adrianludwin]

/lgtm
/approve
/assign @rjbez17
/hold

[rjbez17]

/lgtm
/approve
/hold cancel

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianludwin, rjbez17, sophieliu15

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adrianludwin,rjbez17]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment