This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
Compute NumSourceObjects in HNCConfiguration status #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
sophieliu15
force-pushed
the
num_source_obj_1
branch
from
6746c54 to
ad3ef39
Compare
|
/assign @adrianludwin @adrianchung Feel free to take a look. :) |
adrianludwin
reviewed
Apr 1, 2020
sophieliu15
force-pushed
the
num_source_obj_1
branch
from
ad3ef39 to
c0854d3
Compare
This PR computes NumSourceObjects as a part of HNCConfiguration status. NumSourceObjects indicates the number of source objects of a specific type created by users. Tested: unit tests, GKE cluster Issue: kubernetes-retired#411
sophieliu15
force-pushed
the
num_source_obj_1
branch
from
c0854d3 to
94a826c
Compare
adrianludwin
reviewed
Apr 1, 2020
k8s-ci-robot
added
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin, rjbez17, sophieliu15 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR computes NumSourceObjects as a part of HNCConfiguration status. NumSourceObjects indicates the number of source objects of a specific type created by users.
Tested: unit tests, GKE cluster
Issue: #411