This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
Integrate GK cert as the default internal cert #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
|
/assign @adrianludwin |
yiqigao217
force-pushed
the
self-service-namespace
branch
2 times, most recently
from
ba5c7da to
1b6c5dd
Compare
|
/assign @rjbez17 |
Fork the cert management from open-policy-agent/gatekeeper repo to serve as the default internal cert management for HNC. Add an "enable-internal-cert-management" flag to switch between using the internal cert (integrated Gatekeeper cert) or the external cert "cert-manager". Update main.go to start the controller manager with internal certs first and once the cert files are ready, add other controllers and webhooks if webhook is enabled and internal certs are used. Refactor the cert generation and validator startup into pkg/validators/setup.go. To use external cert-manager, update config/default/kustomization.yaml and manager_auth_proxy_patch.yaml as instructed. Run 'make deploy-cm' before 'make deploy'. Tested on a GKE cluster. The manager restarts 0 times and the webhooks are working as expected. The switch to use cert-manager is tested too.
yiqigao217
force-pushed
the
self-service-namespace
branch
from
1b6c5dd to
c34afd6
Compare
adrianludwin
reviewed
May 1, 2020
There was a problem hiding this comment.
/approve
/lgtm
/hold
/assign @rjbez17
Hey Ryan, how does this look to you?
k8s-ci-robot
added
do-not-merge/hold
yiqigao217
force-pushed
the
self-service-namespace
branch
from
4ee9810 to
c34afd6
Compare
|
/lgtm |
k8s-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin, rjbez17, yiqigao217 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fork the cert management from open-policy-agent/gatekeeper repo to serve
as the default internal cert management for HNC.
Add an "enable-internal-cert-management" flag to switch between using
the internal cert (integrated Gatekeeper cert) or the external cert
"cert-manager".
Update main.go to start the controller manager with internal certs first
and once the cert files are ready, add other controllers and webhooks if
webhook is enabled and internal certs are used.
Refactor the cert generation and validator startup into
pkg/validators/setup.go.
To use external cert-manager, update config/default/kustomization.yaml
and manager_auth_proxy_patch.yaml as instructed. Run 'make deploy-cm'
before 'make deploy'.
Tested on a GKE cluster. The manager restarts 0 times and the webhooks
are working as expected.
Fixes #653