Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Proposal: Switch to dep for dependency management #1665

Closed
arschles opened this issue Jan 11, 2018 · 4 comments
Closed

Proposal: Switch to dep for dependency management #1665

arschles opened this issue Jan 11, 2018 · 4 comments

Comments

@arschles
Copy link
Contributor

dep is the "official experimental" dependency management tool for Go. I believe we should switch from using glide to vendor our dependencies to this tool.

From experience, the major benefit dep has over glide is that its usage is declarative. You run dep ensure and the tool does roughly the following:

  • looks at your imports
  • based on your imports, adds all the packages you need
  • based on your imports, removes all the packages you don't need
  • updates the dependencies file (Gopkg.toml), the lock file (Gopkg.lock), and the vendor directory as needed

The result is that we would no longer need to run glide get to manually add new dependencies. We've also had to do various manual tasks to manage our vendor directory. For example, we've had to rm -rf vendor and then re-run glide install to get a "clean" vendor directory. Dep provides the tools so we don't have to do that anymore.

@carolynvs
Copy link
Contributor

I'd be happy to provide assistance on this one, or help answer dep questions.

Disclaimer: I am a maintainer for dep and am actively working on features to make dep better for kubernetes libraries. 😇

@pmorie
Copy link
Contributor

pmorie commented Jan 12, 2018

This seems to be where things are headed in the k8s community. I have heard good things about dep's dependency pruning capabilities and have found adding dependencies or updating a subset of dependencies to be extremely painful with glide. @carolynvs if you have the cycles, you're welcome to do this IMO

@MHBauer
Copy link
Contributor

MHBauer commented Jan 12, 2018

I want to see dep as soon as possible as widely as possible. It does seem like it will be the go official tool.

As long as I have the ability to check out and build, I am happy. I have not run anything glide related in quite a while.

@nilebox probably has done the most dependency probing and updating.

@carolynvs
Copy link
Contributor

Sweet! I'll work on this next week.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants