Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Prune vendor directory? #1722

Closed
carolynvs opened this issue Feb 8, 2018 · 2 comments · Fixed by #1739
Closed

Prune vendor directory? #1722

carolynvs opened this issue Feb 8, 2018 · 2 comments · Fixed by #1739

Comments

@carolynvs
Copy link
Contributor

When I migrated us to dep, I didn't turn on pruning because of a gap in dep, and how it treats the code-generator repo that caused dep to no properly vendor the non-go code in that repo. Once golang/dep#1545 is merged however, we can turn pruning on if we like.

Do we want to?

@MHBauer
Copy link
Contributor

MHBauer commented Feb 13, 2018

Is pruning 'do not include packages we never call'? If so, why not?

@carolynvs
Copy link
Contributor Author

There are three pruning options available:

  • Unused packages - Remove packages that aren't imported
  • Non-go code - Removes files not used by go
  • Go tests - Removes *_test.go files

I'll submit a PR that demonstrates this, and my workaround for not having that dep PR merged yet. Should be able to remove quite a bit of cruft.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants