CSI controller Health Check doesn't properly validate controller health.

[stobias123]

/kind bug

What happened?
Volumes could not attach. I had a combination of these two errors. After restarting the CSI driver deployment, the volumes attached properly.

E0328 19:16:27.445502       1 driver.go:120] "GRPC error" err="rpc error: code = Internal desc = Could not attach volume \"vol-02a81309e3377eebb\" to node \"i-0c9f3cd3ae6b2d20d\": attachment of disk \"vol-02a81309e3377eebb\" failed, expected device to be attached but was attaching"
I0328 19:16:58.979598       1 cloud.go:611] "Ignoring error from describe volume, will retry" volumeID="vol-02a81309e3377eebb" err=<
        RequestCanceled: request context canceled
        caused by: context deadline exceeded

What you expected to happen?

I'd expect this time out failure to surface in the healthcheck and cause the pod to be restarted. If the healthcheck fails, and restarts the pod, things would have auto healed without user input.

How to reproduce it (as minimally and precisely as possible)?

Anything else we need to know?:
I had a support case open for this. 12358592881.

Environment

• Kubernetes version (use kubectl version): v1.23.16-eks-48e63af
• Driver version: v1.17.0-eksbuild.1

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[AndrewSirenko]

/remove-lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[stobias123]

Bummer! Any reason we can't keep this open? I think my concern is still valid here.

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[AndrewSirenko]

/remove-lifecycle rotten

@stobias123 yes we should be keeping this open. I'll bring this issue back up at today's standup. Thank you for your patience.

[AndrewSirenko]

/priority important-longterm