Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality of life changes to the aws-efs-csi-driver helm chart. #1274

Open
RadOctocode opened this issue Feb 20, 2024 · 3 comments
Open

Quality of life changes to the aws-efs-csi-driver helm chart. #1274

RadOctocode opened this issue Feb 20, 2024 · 3 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@RadOctocode
Copy link
Contributor

RadOctocode commented Feb 20, 2024

Is your feature request related to a problem?/Why is this needed
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
I want to add some quality of life changes to the helm chart for the aws-efs-csi-driver. I have a patched version of these charts and would like to contribute the changes made.
/feature

Describe the solution you'd like in detail
A clear and concise description of what you want to happen.
I would like to include the following quality of life changes

  • In node-daemonset.yaml
    • templatize priorityClassName
    • include pod labels
    • use values for hostNetwork
  • In storageclass.yaml
    • add .metadata

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
the user could patch the chart each time before using it.
Additional context
Add any other context or screenshots about the feature request here.

@RadOctocode
Copy link
Contributor Author

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 29, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants