Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating goreleaser yaml to fix deprecated options #252

Merged
merged 2 commits into from
Aug 18, 2019
Merged

Updating goreleaser yaml to fix deprecated options #252

merged 2 commits into from
Aug 18, 2019

Conversation

hyperbolic2346
Copy link
Contributor

archive and docker binary options have changed.

Fixes #251

@k8s-ci-robot
Copy link
Contributor

Welcome @hyperbolic2346!

It looks like this is your first PR to kubernetes-sigs/aws-iam-authenticator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-iam-authenticator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 12, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 12, 2019
@christopherhein
Copy link
Member

Thanks for the PR @hyperbolic2346 can you also update the Travis build script to download the newer release?

https://github.com/kubernetes-sigs/aws-iam-authenticator/blob/master/.travis.yml#L12

@hyperbolic2346
Copy link
Contributor Author

Thanks for the PR @hyperbolic2346 can you also update the Travis build script to download the newer release?

https://github.com/kubernetes-sigs/aws-iam-authenticator/blob/master/.travis.yml#L12

Updated to v0.115.0, which is the latest release.

@christopherhein
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, hyperbolic2346

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2019
@christopherhein
Copy link
Member

Thank you for the PR @hyperbolic2346

@k8s-ci-robot k8s-ci-robot merged commit 82c8c5e into kubernetes-sigs:master Aug 18, 2019
joanayma pushed a commit to joanayma/aws-iam-authenticator that referenced this pull request Aug 11, 2021
@stefansedich @max-rocket-internet
Worker group tags (kubernetes-sigs#252)
35747d7 
* Allow per worker group ASG tags to be set

* Format

* Set correct defaults

* Implement hack that will use the first item in the list if a matching item does not exist for the worker group

* Use a map that will map from the worker group name to the tags to get around the issue where list indexing does not work with a list of lists

* Format

* Cleanup

* Fix sample

* README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caarlos0 caarlos0 caarlos0 approved these changes

@christopherhein christopherhein Awaiting requested review from christopherhein

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@christopherhein christopherhein

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

goreleaser format changes have caused broken build
4 participants
@hyperbolic2346 @k8s-ci-robot @christopherhein @caarlos0