-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to allow configurable backends (configmap, eks configmap, crd) #269
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Will put last 2 commits in a separate PR. Some concerns about whether the user has sts regional endpoints activated or not. |
15f226e
to
06c7c60
Compare
@wongma7 awesome, yeah I think the regional endpoint is a separate concern. |
b43b647
to
d9ecbee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a bunch of TODOs, do we want to address those in this PR or at a later time?
Thanks for doing this!
I think tests can be a follow-up. But I need to update the documentation (and fix the travis build). Will ping when that is ready. |
40c9f5c
to
da63a56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we are close 😄
Do we have a test with multiple backends?
…leARN', 'userARN', work
f3aa433
to
ce237f9
Compare
RE: tests there are a couple tests that inadvertently use multiple mappers but no explicit tests yet. https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/269/files#diff-8151a8a5ca3b510f06b426f0cfb48708R646 I would like to refactor server_test.go in a followup as it will be quite verbose to have a configmap+file+crd version of every testcase. Then add some explicit tests. |
ce237f9
to
e362ffd
Compare
/lgtm |
This enables the authenticator server to support multiple backends (sources of IAM->user+group mappings) at the same time with a well-defined order of precedence according to the backend-mode argument.
Fixes #247
also fixes #261
TODO: more tests -- will do in a follow-up
TODO: update README-- doneTODO: fix server_test.go-- doneTODO: sts regional endpoint -- needs some discussion, will do in a follow-up