Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sts error metric #430

Merged
merged 1 commit into from
Feb 14, 2022
Merged

add sts error metric #430

merged 1 commit into from
Feb 14, 2022

Conversation

jyotimahapatra
Copy link
Contributor

Signed-off-by: Jyoti Mahapatra jyotima@amazon.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 10, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @jyotimahapatra. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 10, 2022
@jyotimahapatra
Copy link
Contributor Author

/assign @wongma7

@wongma7
Copy link
Contributor

wongma7 commented Feb 10, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 10, 2022
wongma7
wongma7 reviewed Feb 10, 2022
View reviewed changes
pkg/metrics/metrics.go Outdated Show resolved Hide resolved
@jyotimahapatra jyotimahapatra force-pushed the sts branch 2 times, most recently from ff97dcb to 09121be Compare February 10, 2022 20:16
nckturner
nckturner reviewed Feb 11, 2022
View reviewed changes
pkg/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/token/token_test.go Outdated Show resolved Hide resolved
pkg/token/token.go Outdated Show resolved Hide resolved
@jyotimahapatra jyotimahapatra force-pushed the sts branch 3 times, most recently from c1b875c to 0625b60 Compare February 11, 2022 18:47
wongma7
wongma7 reviewed Feb 11, 2022
View reviewed changes
pkg/token/token.go Outdated Show resolved Hide resolved
@nckturner
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 11, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2022
@nckturner
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jyotimahapatra, nckturner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2022
@nckturner
Copy link
Contributor

nckturner commented Feb 11, 2022 •
edited
Loading

@jyotimahapatra please fix the merge conflict

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 11, 2022
@jyotimahapatra
add sts error metric
6177abd 
Signed-off-by: Jyoti Mahapatra <jyotima@amazon.com>
@jyotimahapatra
Copy link
Contributor Author

@nckturner ..rebased and ready

@nckturner
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 39916f8 into kubernetes-sigs:master Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wongma7 wongma7 wongma7 left review comments

@nckturner nckturner nckturner left review comments

@jaypipes jaypipes Awaiting requested review from jaypipes

@micahhausler micahhausler Awaiting requested review from micahhausler

Assignees

@nckturner nckturner

@wongma7 wongma7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jyotimahapatra @k8s-ci-robot @wongma7 @nckturner