fix: allow special char in tag value

kubernetes-sigs · Mar 29, 2024 · 3e9f60a · 3e9f60a
1 parent 32262e9
commit 3e9f60a
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/pkg/azuredisk/azure_managedDiskController.go b/pkg/azuredisk/azure_managedDiskController.go
@@ -124,10 +124,10 @@ func (c *ManagedDiskController) CreateManagedDisk(ctx context.Context, options *
 	newTags[consts.CreatedByTag] = &azureDDTag
 	if options.Tags != nil {
 		for k, v := range options.Tags {
-			// Azure won't allow / (forward slash) in tags
-			newKey := strings.Replace(k, "/", "-", -1)
-			newValue := strings.Replace(v, "/", "-", -1)
-			newTags[newKey] = &newValue
+			// <>%&?/. are not allowed in tag key, but allowed in tag value
+			newKey := strings.NewReplacer("<", "-", ">", "-", "%", "-", "&", "-", "?", "-", "/", "-").Replace(k)
+			value := v
+			newTags[newKey] = &value
 		}
 	}